Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix encode_to_iodata/1 not matching encode/1 behaviour #397

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Fix encode_to_iodata/1 not matching encode/1 behaviour #397

merged 3 commits into from
Jan 14, 2025

Conversation

v0idpwn
Copy link
Collaborator

@v0idpwn v0idpwn commented Jan 14, 2025

Only encode/1 was applying transform in the outer struct

@v0idpwn
Fix encode_to_iodata/1 not matching encode/1 behaviour
3c3b871 
Only encode/1 was applying transform in the outer struct
@v0idpwn
make it work
6e4a3c5
v0idpwn
v0idpwn commented Jan 14, 2025
View reviewed changes
lib/protobuf/encoder.ex Outdated Show resolved Hide resolved
@v0idpwn v0idpwn merged commit 62dfa12 into main Jan 14, 2025
4 checks passed
@v0idpwn v0idpwn deleted the fix/transform-encode branch January 14, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@v0idpwn